MPT-16242 Add iterate in expected methods for catalog resources#150
Merged
albertsola merged 1 commit intomainfrom Dec 8, 2025
Merged
MPT-16242 Add iterate in expected methods for catalog resources#150albertsola merged 1 commit intomainfrom
iterate in expected methods for catalog resources#150albertsola merged 1 commit intomainfrom
Conversation
albertsola
requested review from
alephsur,
d3rky,
jentyk,
robcsegal,
ruben-sebrango and
svazquezco
as code owners
WalkthroughAdded the "iterate" method to parameterized mixin presence checks in 16 unit tests under tests/unit/resources/catalog, expanding each test's asserted public method list for both sync and async service classes. No production code or control-flow changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (16)
🚧 Files skipped from review as they are similar to previous changes (8)
🧰 Additional context used🧬 Code graph analysis (4)tests/unit/resources/catalog/test_price_list_items.py (17)
tests/unit/resources/catalog/test_price_lists.py (13)
tests/unit/resources/catalog/test_units_of_measure.py (16)
tests/unit/resources/catalog/test_listings.py (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (8)
Comment |
robcsegal
approved these changes
Dec 5, 2025
svazquezco
approved these changes
Dec 5, 2025
albertsola
force-pushed
the
add-iterate-unit-tests
branch
from
f2c0306 to
f87a613
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.